Re: [PATCH] tools/mm/page_owner_sort.c: fix TGID output when cull=tg is used

[Andrew Morton]

On Tue, 11 Apr 2023 11:49:28 +0800 Steve Chou <steve_chou@xxxxxxxxxxx> wrote:

> When using cull option with 'tg' flag, the fprintf is using pid instead
> of tgid. It should use tgid instead.
> 
> ...
>
> --- a/tools/mm/page_owner_sort.c
> +++ b/tools/mm/page_owner_sort.c
> @@ -857,7 +857,7 @@ int main(int argc, char **argv)
>  			if (cull & CULL_PID || filter & FILTER_PID)
>  				fprintf(fout, ", PID %d", list[i].pid);
>  			if (cull & CULL_TGID || filter & FILTER_TGID)
> -				fprintf(fout, ", TGID %d", list[i].pid);
> +				fprintf(fout, ", TGID %d", list[i].tgid);
>  			if (cull & CULL_COMM || filter & FILTER_COMM)
>  				fprintf(fout, ", task_comm_name: %s", list[i].comm);
>  			if (cull & CULL_ALLOCATOR) {

Thanks, copy-paste error, I expect.  I'll add Fixes: 9c8a0a8e599
("tools/vm/page_owner_sort.c: support for user-defined culling rules")
and cc:stable.