RE: [PATCH v3 0/3] regulator: da9063: disable unused voltage monitors

[DLG Adam Ward]

On 05/04/2023, 19:14, Benjamin Bara wrote: 

>Hi!
>
>Follow-up for my initial patch regarding the disabling of unused
>voltage monitors. We use the PWR_OK functionality, which asserts GP_FB2
>if every monitored voltage is in range. This patch should provide the
>possibility to deactivate a voltage monitor from the DT if the regulator
>might be disabled during run time. For this purpose, the regulator
>notification support is used:
>https://lore.kernel.org/all/cover.1622628333.git.matti.vaittinen@xxxxxxxxxxxxxxxxx/
>
>v2: https://lore.kernel.org/r/20230403-da9063-disable-unused-v2-0-2f1bd2a2434a@xxxxxxxxxxx
>
>---
>Changelog:
>v3:
>2:
>- add clarifications, reword XVP to voltage monitoring
>- improve error messages
>- ensure that only one severity is set
>3:
-> document that ov and uv require same severity and level
>
>v2:
>- reworked solution, based on Adam Thomson's feedback
>
>---
>Benjamin Bara (3):
>      regulator: da9063: add voltage monitoring registers
>      regulator: da9063: implement setter for voltage monitoring
>      dt-bindings: mfd: dlg,da9063: document voltage monitoring
>
> .../devicetree/bindings/mfd/dlg,da9063.yaml        |  17 ++-
> drivers/regulator/da9063-regulator.c               | 147 +++++++++++++++++----
> include/linux/mfd/da9063/registers.h               |  23 ++++
> 3 files changed, 157 insertions(+), 30 deletions(-)
>---
>base-commit: 7e364e56293bb98cae1b55fd835f5991c4e96e7d
>change-id: 20230403-da9063-disable-unused-15836e2f4539
>
>Best regards,
>-- 
>Benjamin Bara <benjamin.bara@xxxxxxxxxxx>

Hi Benjamin,

FYI, Adam Thomson has left the company - but, being on excellent terms, kindly added his informed reading of your latest patch set to my own.

Reviewed-by: Adam Ward <DLG-Adam.Ward.opensource@xxxxxxxxxxxxxx>

Thanks and kind regards,
Adam