Re: [PATCH v2 00/17] MT6795 Helio X10 and Sony Xperia M5: DT step 2!

[Matthias Brugger]

On 02/04/2023 19:26, Matthias Brugger wrote:
> On 27/03/2023 10:36, AngeloGioacchino Del Regno wrote:
> > Changes in v2:
> >   - Squashed the addition of mediatek,mt6795-gce.h header with the
> >     commit adding the MT6795 GCE compatible.
> >
> > This series further enhances the support for the MT6795 Helio X10 SoC
> > and the Sony Xperia M5 smartphone.
> >
> > In particular, for the SoC support, this adds:
> >   - Frequency Hopping support
> >   - I2C controllers
> >   - Power domains
> >   - IOMMU support and LARBs
> >   - GCE/CMDQ Mailbox
> >   - VDECSYS and VENCSYS clocks
> >   - MMSYS support
> >
> > ...and, on the Xperia M5 smartphone, this adds:
> >   - Frequency Hopping with Spread Spectrum for MAINPLL, MPLL, MSDCPLL
> >   - Touchscreen support (Synaptics S2726, fw id: 1898977, RMI4 protocol)
> >   - Accelerometer
> >   - Magnetometer
> >   - Proximity sensor
> >   - NFC support
> >
> > ...all of which was successfully tested on the Xperia M5 smartphone.
> >
> > This series depends on [1] for the MMSYS support.
> >
> > Plan for step 3 is to push upstream full display support, which does
> > already work on my custom tree ;-)
> >
> > [1]: 
> > https://lore.kernel.org/all/20230309102618.114157-1-angelogioacchino.delregno@xxxxxxxxxxxxx/
> >
> > Cheers!
>
> Applied all but:
> 4/17 dt-binding already applied
> 7/17 dt-binding not applied
> 8/17 we are missing the dt binding

I dropped the following patches for now:
09/17 and 11/17 due to missing 07/17 this break creation of DTBs.

I also dopped 14/17 and 15/17 as buidling the DTBs gave the following warning:
arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:104.21-109.4: Warning 
(unit_address_format): /soc/i2c@11010000/accelerometer@0x10: unit name should 
not have leading "0x"
arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:111.20-114.4: Warning 
(unit_address_format): /soc/i2c@11010000/magnetometer@0x12: unit name should not 
have leading "0x"
arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:104.21-109.4: Warning 
(i2c_bus_reg): /soc/i2c@11010000/accelerometer@0x10: I2C bus unit address format 
error, expected "10"
arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:111.20-114.4: Warning 
(i2c_bus_reg): /soc/i2c@11010000/magnetometer@0x12: I2C bus unit address format 
error, expected "12"

Regards,
Matthias

> Thanks a lot for the great work
> Matthias
>
> > AngeloGioacchino Del Regno (17):
> >    arm64: dts: mediatek: mt6795: Add Frequency Hopping Controller node
> >    arm64: dts: mediatek: mt6795: Add apmixedsys syscon node
> >    arm64: dts: mediatek: mt6795: xperia-m5: Enable Frequency Hopping
> >    dt-bindings: i2c: i2c-mt65xx: Add compatible for MT6795 Helio X10
> >    arm64: dts: mediatek: mt6795: Add nodes for I2C controllers
> >    arm64: dts: mediatek: mt6795: Add SoC power domains
> >    dt-bindings: mailbox: mediatek,gce-mailbox: Add support for MT6795
> >    arm64: dts: mediatek: mt6795: Add support for the CMDQ/GCE mailbox
> >    arm64: dts: mediatek: mt6795: Add MMSYS node for multimedia clocks
> >    arm64: dts: mediatek: mt6795: Add VDECSYS and VENCSYS clocks
> >    arm64: dts: mediatek: mt6795: Add support for IOMMU and LARBs
> >    arm64: dts: mediatek: mt6795-xperia-m5: Enable I2C 0-3 busses
> >    arm64: dts: mediatek: mt6795-xperia-m5: Add Synaptics RMI4 Touchscreen
> >    arm64: dts: mediatek: mt6795-xperia-m5: Add Bosch BMA255 Accelerometer
> >    arm64: dts: mediatek: mt6795-xperia-m5: Add Bosch BMM050 Magnetometer
> >    arm64: dts: mediatek: mt6795-xperia-m5: Add Sensortek STK3310
> >      Proximity
> >    arm64: dts: mediatek: mt6795-xperia-m5: Add NXP PN547 NFC on I2C3
> >
> >   .../devicetree/bindings/i2c/i2c-mt65xx.yaml   |   4 +
> >   .../mailbox/mediatek,gce-mailbox.yaml         |  20 +-
> >   .../dts/mediatek/mt6795-sony-xperia-m5.dts    | 166 ++++++++++++
> >   arch/arm64/boot/dts/mediatek/mt6795.dtsi      | 245 ++++++++++++++++++
> >   include/dt-bindings/gce/mediatek,mt6795-gce.h | 123 +++++++++
> >   5 files changed, 550 insertions(+), 8 deletions(-)
> >   create mode 100644 include/dt-bindings/gce/mediatek,mt6795-gce.h