Re: [PATCH v3] UML: pata_cs5536: fix build for X86_32 UML with TRACEPOINTS
From: kernel test robot
Date: Tue Apr 11 2023 - 13:03:04 EST
Hi Randy,
kernel test robot noticed the following build warnings:
[auto build test WARNING on uml/next]
[also build test WARNING on uml/fixes wireless-next/main wireless/main linus/master v6.3-rc6 next-20230411]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Randy-Dunlap/UML-pata_cs5536-fix-build-for-X86_32-UML-with-TRACEPOINTS/20230410-091733
base: git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux next
patch link: https://lore.kernel.org/r/20230410011325.26850-1-rdunlap%40infradead.org
patch subject: [PATCH v3] UML: pata_cs5536: fix build for X86_32 UML with TRACEPOINTS
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20230412/202304120048.v4uqUq9Q-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/2782ce24954318f1698ec910691250f4d287d817
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Randy-Dunlap/UML-pata_cs5536-fix-build-for-X86_32-UML-with-TRACEPOINTS/20230410-091733
git checkout 2782ce24954318f1698ec910691250f4d287d817
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=um SUBARCH=i386 olddefconfig
make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202304120048.v4uqUq9Q-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> arch/x86/um/../lib/msr.c:30: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Read an MSR with error handling
arch/x86/um/../lib/msr.c:52: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Write an MSR with error handling
arch/x86/um/../lib/msr.c:91: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Set @bit in a MSR @msr.
arch/x86/um/../lib/msr.c:104: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Clear @bit in a MSR @msr.
vim +30 arch/x86/um/../lib/msr.c
22085a66c2fab6 Borislav Petkov 2014-03-09 28
22085a66c2fab6 Borislav Petkov 2014-03-09 29 /**
22085a66c2fab6 Borislav Petkov 2014-03-09 @30 * Read an MSR with error handling
22085a66c2fab6 Borislav Petkov 2014-03-09 31 *
22085a66c2fab6 Borislav Petkov 2014-03-09 32 * @msr: MSR to read
22085a66c2fab6 Borislav Petkov 2014-03-09 33 * @m: value to read into
22085a66c2fab6 Borislav Petkov 2014-03-09 34 *
22085a66c2fab6 Borislav Petkov 2014-03-09 35 * It returns read data only on success, otherwise it doesn't change the output
22085a66c2fab6 Borislav Petkov 2014-03-09 36 * argument @m.
22085a66c2fab6 Borislav Petkov 2014-03-09 37 *
22085a66c2fab6 Borislav Petkov 2014-03-09 38 */
3e7bbe15ed84e3 Zhao Xuehui 2021-04-08 39 static int msr_read(u32 msr, struct msr *m)
22085a66c2fab6 Borislav Petkov 2014-03-09 40 {
22085a66c2fab6 Borislav Petkov 2014-03-09 41 int err;
22085a66c2fab6 Borislav Petkov 2014-03-09 42 u64 val;
22085a66c2fab6 Borislav Petkov 2014-03-09 43
22085a66c2fab6 Borislav Petkov 2014-03-09 44 err = rdmsrl_safe(msr, &val);
22085a66c2fab6 Borislav Petkov 2014-03-09 45 if (!err)
22085a66c2fab6 Borislav Petkov 2014-03-09 46 m->q = val;
22085a66c2fab6 Borislav Petkov 2014-03-09 47
22085a66c2fab6 Borislav Petkov 2014-03-09 48 return err;
22085a66c2fab6 Borislav Petkov 2014-03-09 49 }
22085a66c2fab6 Borislav Petkov 2014-03-09 50
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests