Re: [PATCH v2 6/7] thermal/drivers/acpi: Make cross dev link optional by configuration
From: Daniel Lezcano
Date: Tue Apr 11 2023 - 16:22:30 EST
On 11/04/2023 20:26, Rafael J. Wysocki wrote:
On Mon, Apr 10, 2023 at 10:53 PM Daniel Lezcano
<daniel.lezcano@xxxxxxxxxx> wrote:
The ACPI thermal driver creates a link in the thermal zone device
sysfs directory pointing to the device sysfs directory. At the same
time, it creates a back pointer link from the device to the thermal
zone device sysfs directory.
From a generic perspective, having a device pointer in the sysfs
thermal zone directory may make sense. But the opposite is not true as
the same driver can be related to multiple thermal zones.
The usage of these information is very specific to ACPI and it is
questionable if they are really needed.
Let's make the code optional and disable it by default.
Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
---
drivers/acpi/thermal.c | 62 ++++++++++++++++++++++++++++--------------
1 file changed, 42 insertions(+), 20 deletions(-)
diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
index 5763db4528b8..70f1d28810f2 100644
--- a/drivers/acpi/thermal.c
+++ b/drivers/acpi/thermal.c
@@ -787,9 +787,44 @@ static struct thermal_zone_device_ops acpi_thermal_zone_ops = {
.critical = acpi_thermal_zone_device_critical,
};
+#ifdef CONFIG_THERMAL_SYSFS_OBSOLETE_SINGULARITY
It is OK to move the code to the separate functions below, but it is
not OK to make it depend on the Kconfig option above.
The extra sysfs things were added in different drivers for different
reasons. Making them all depend on one Kconfig option is just wrong.
Ok, I'll do the changes accordingly.
Thanks for reviewing the series
[ ... ]
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog