Re: [PATCH] scsi: lpfc: silence an incorrect device output

[Justin Tee]

Hi Jun,

Broadcom no longer supports LPFC_SLI_INTF_IF_TYPE_1 adapters, but the
patch looks fine.

Reviewed-by: Justin Tee <justin.tee@xxxxxxxxxxxx>

Thanks,
Justin

On Sun, Apr 9, 2023 at 8:14 PM Jun Chen <jun_c@xxxxxxxxxxx> wrote:
>
> In lpfc_sli4_pci_mem_unset, case LPFC_SLI_INTF_IF_TYPE_1 does not have a
> break statement, resulting in an incorrect device output.
>
> Fix this by adding a break statement before the default option.
>
> Signed-off-by: Jun Chen <jun_c@xxxxxxxxxxx>
> Reviewed-by: Dongliang Mu <dzm91@xxxxxxxxxxx>
> ---
>  drivers/scsi/lpfc/lpfc_init.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index d062220d3232..da3a45441639 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -12105,6 +12105,7 @@ lpfc_sli4_pci_mem_unset(struct lpfc_hba *phba)
>                         iounmap(phba->sli4_hba.dpp_regs_memmap_p);
>                 break;
>         case LPFC_SLI_INTF_IF_TYPE_1:
> +               break;
>         default:
>                 dev_printk(KERN_ERR, &phba->pcidev->dev,
>                            "FATAL - unsupported SLI4 interface type - %d\n",
> --
> 2.25.1
>