Re: [RFC PATCH v2 net-next 06/14] net: dsa: mt7530: do not set CPU port interfaces to PHY_INTERFACE_MODE_NA

[Arınç ÜNAL]

On 11.04.2023 17:54, Vladimir Oltean wrote:
> On Fri, Apr 07, 2023 at 04:46:18PM +0300, arinc9.unal@xxxxxxxxx wrote:
> > From: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
> >
> > There is no need to set priv->p5_interface and priv->p6_interface to
> > PHY_INTERFACE_MODE_NA on mt7530_setup() and mt7531_setup().
> >
> > As Vladimir explained, in include/linux/phy.h we have:
> >
> > Therefore, do not put 0 into a variable containing 0.
>
> The explanation is unnecessarily long. I only provided it to make sure
> you understand.

I don't see a problem with a bit of verbosity on the patch log. It 
should make the reader understand the code path better.

Arınç