Re: [PATCH] fs: fix sysctls.c built

[Christian Brauner]

On Tue, Apr 11, 2023 at 12:14:44PM +0800, Kefeng Wang wrote:
> /proc/sys/fs/overflowuid and overflowgid  will be lost without
> building this file, kindly ping, any comments, thanks.
> 
> 
> On 2023/3/31 16:45, Kefeng Wang wrote:
> > 'obj-$(CONFIG_SYSCTL) += sysctls.o' must be moved after "obj-y :=",
> > or it won't be built as it is overwrited.
> > 
> > Fixes: ab171b952c6e ("fs: move namespace sysctls and declare fs base directory")
> > Signed-off-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>
> > ---
> >   fs/Makefile | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/fs/Makefile b/fs/Makefile
> > index 05f89b5c962f..8d4736fcc766 100644
> > --- a/fs/Makefile
> > +++ b/fs/Makefile
> > @@ -6,7 +6,6 @@
> >   # Rewritten to use lists instead of if-statements.
> >   #
> > -obj-$(CONFIG_SYSCTL)		+= sysctls.o
> >   obj-y :=	open.o read_write.o file_table.o super.o \
> >   		char_dev.o stat.o exec.o pipe.o namei.o fcntl.o \
> > @@ -50,7 +49,7 @@ obj-$(CONFIG_FS_MBCACHE)	+= mbcache.o
> >   obj-$(CONFIG_FS_POSIX_ACL)	+= posix_acl.o
> >   obj-$(CONFIG_NFS_COMMON)	+= nfs_common/
> >   obj-$(CONFIG_COREDUMP)		+= coredump.o
> > -obj-$(CONFIG_SYSCTL)		+= drop_caches.o
> > +obj-$(CONFIG_SYSCTL)		+= drop_caches.o sysctls.o
> >   obj-$(CONFIG_FHANDLE)		+= fhandle.o
> >   obj-y				+= iomap/

Given the description in
ab171b952c6e ("fs: move namespace sysctls and declare fs base directory")
you probably want to move this earlier.