Re: [PATCH v2 2/2] ARM: dts: mvebu: add Thecus N2350 board DTS

[Tony Dinh]

Hi Andrew,

On Wed, Apr 12, 2023 at 5:24 AM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> > +
> > +/ {
> > +     model = "Thecus N2350";
> > +     compatible = "marvell,armada385";
>
> If you look at all the other armarda-385 .dts files, they all have a
> board compatible. It might not be needed now, but it could be useful
> in the future and allow backwards compatibility.
>
> > +&mdio {
> > +     phy0: ethernet-phy@0 {
> > +             reg = <1>;
> > +     };
> > +};
>
> Since you have ref = <1>, this should be ethernet-phy@1.
>

Thanks! somehow I kept missing that change.

All the best,
Tony