Re: [PATCH 1/2] x86: profiling: remove lock functions hack for !FRAME_POINTER

From: Chen Zhongjin
Date: Thu Apr 13 2023 - 03:53:13 EST



On 2023/4/12 18:01, David Laight wrote:
From: Chen Zhongjin
Sent: 12 April 2023 08:02
...
4. !CONFIG_FRAME_POINTER is probably even more rare today than it was in
2006
No. !CONFIG_FRAME_POINTER is more common today because of UNWINDER_ORC.
And that is why the bug is triggered more frequently.
CONFIG_FRAME_POINTER is pretty much required (on x86-64)
for the user copy checks that are enabled in distro kernels.

Thanks for reminding.. I know little about distro kernels.

I though at least !CONFIG_FRAME_POINTER is more common than it was in 2006.
Not investigated but just because UNWINDER_ORC is defconfig and it disables CONFIG_FRAME_POINTER.

Anyway, I kept the CONFIG_FRAME_POINTER not removed so it won't be affected.

Best,
Chen
David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)