Re: [PATCH] platform/x86/intel/sdsi: Change mailbox timeout

[Ilpo Järvinen]

On Wed, 12 Apr 2023, David E. Box wrote:

> On some platforms, it may take up to 400ms for the ready bit to be set in a
> successful mailbox transaction. Set the timeout to 500ms to cover the worst
> case.
> 
> Signed-off-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx>
> ---
>  drivers/platform/x86/intel/sdsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/intel/sdsi.c
> index 9e0ea2cdd704..556e7c6dbb05 100644
> --- a/drivers/platform/x86/intel/sdsi.c
> +++ b/drivers/platform/x86/intel/sdsi.c
> @@ -49,7 +49,7 @@
>  #define SDSI_MBOX_CMD_SUCCESS		0x40
>  #define SDSI_MBOX_CMD_TIMEOUT		0x80
>  
> -#define MBOX_TIMEOUT_US			2000
> +#define MBOX_TIMEOUT_US			500000
>  #define MBOX_TIMEOUT_ACQUIRE_US		1000
>  #define MBOX_POLLING_PERIOD_US		100
>  #define MBOX_ACQUIRE_NUM_RETRIES	5

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

-- 
 i.