Re: [PATCH v6 3/3] mm: vmscan: refactor updating current->reclaim_state

From: David Hildenbrand
Date: Thu Apr 13 2023 - 07:21:56 EST


On 13.04.23 12:40, Yosry Ahmed wrote:
During reclaim, we keep track of pages reclaimed from other means than
LRU-based reclaim through scan_control->reclaim_state->reclaimed_slab,
which we stash a pointer to in current task_struct.

However, we keep track of more than just reclaimed slab pages through
this. We also use it for clean file pages dropped through pruned inodes,
and xfs buffer pages freed. Rename reclaimed_slab to reclaimed, and add

Would "reclaimed_non_lru" be more expressive? Then,

mm_account_reclaimed_pages() -> mm_account_non_lru_reclaimed_pages()


Apart from that LGTM.

--
Thanks,

David / dhildenb