Re: [PATCH] PCI: hv: Use nested hypercall for retargeting interrupts

[Wei Liu]

On Thu, Apr 13, 2023 at 03:05:09AM +0000, Michael Kelley (LINUX) wrote:
> From: Wei Liu <wei.liu@xxxxxxxxxx> Sent: Wednesday, April 12, 2023 6:23 PM
> > 
> > On Tue, Apr 04, 2023 at 11:35:46AM +0000, Jinank Jain wrote:
> > > In case of nested MSHV, retargeting interrupt hypercall should be sent
> > > to L0 hypervisor instead of L1 hypervisor.
> > >
> > > Signed-off-by: Jinank Jain <jinankjain@xxxxxxxxxxxxxxxxxxx>
> > 
> > Applied to hyperv-next. Thanks.
> 
> I'd like to hold off on taking this change.  Nuno and I are discussing
> how best to handle nested hypercalls.  In addition to the proposed
> nested changes,  we have hypercall changes coming as part of the
> TDX and fully enlightened SNP patch sets.  If possible, I'd like to
> avoid adding logic at the hv_do_hypercall() call sites.  It's not clear
> whether avoiding such logic will really be feasible, but I'd like to
> think about it for a bit before reaching that conclusion.

I thought that discussion will go on for a while but this patch fixed a
real bug.

Holding off is fine too. I will remove this patch from hyperv-next.

Thanks,
Wei.

> 
> Michael
>