Re: [PATCH v6 0/8] Add multiport support for DWC3 controllers

From: Adrien Thierry
Date: Thu Apr 13 2023 - 14:55:35 EST


Hi,

> Krishna Kurapati (8):
> dt-bindings: usb: Add bindings for multiport properties on DWC3
> controller
> usb: dwc3: core: Access XHCI address space temporarily to read port
> info
> usb: dwc3: core: Skip setting event buffers for host only controllers
> usb: dwc3: core: Refactor PHY logic to support Multiport Controller
> usb: dwc3: qcom: Add multiport controller support for qcom wrapper
> arm64: dts: qcom: sc8280xp: Add multiport controller node for SC8280
> arm64: dts: qcom: sa8295p: Enable tertiary controller and its 4 USB
> ports
> arm64: dts: qcom: sa8540-ride: Enable first port of tertiary usb
> controller
>
> .../devicetree/bindings/usb/snps,dwc3.yaml | 13 +-
> arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 47 +++
> arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 22 ++
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 58 +++
> drivers/usb/dwc3/core.c | 373 ++++++++++++++----
> drivers/usb/dwc3/core.h | 71 +++-
> drivers/usb/dwc3/drd.c | 13 +-
> drivers/usb/dwc3/dwc3-qcom.c | 28 +-
> 8 files changed, 523 insertions(+), 102 deletions(-)

I tested this series on the sa8540p-ride, with a USB Ethernet adapter
plugged into the board. The device shows up as expected:

# lsusb -tv
/: Bus 02.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/2p, 10000M
ID 1d6b:0003 Linux Foundation 3.0 root hub
|__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 5000M
ID 0bda:8153 Realtek Semiconductor Corp. RTL8153 Gigabit Ethernet Adapter
/: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/4p, 480M
ID 1d6b:0002 Linux Foundation 2.0 root hub

Tested-by: Adrien Thierry <athierry@xxxxxxxxxx> # sa8540p-ride