Re: [PATCH] serial: 8250: Clear port->pm on port specific driver unbind
From: Tony Lindgren
Date: Fri Apr 14 2023 - 01:47:32 EST
* Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> [230413 16:06]:
> On Thu, Apr 13, 2023 at 10:03:41AM +0300, Tony Lindgren wrote:
> > Let's fix the issue by clearing port->pm in serial8250_unregister_port().
>
> Sounds to me like a fix that needs a Fixes tag.
Maybe commit c161afe9759d ("8250: allow platforms to override PM hook.").
That's a bit unclear though as the hardware specific functions were
available at that point as they were passed in platform data. This can
be seen with git blame c161afe9759d drivers/serial/8250.c. To me it seems
the port->pm became potentially invalid if a serial port device driver
started implementing PM runtime?
Maybe just tagging it with Cc: stable is better if no obvious Fixes tag
can be figured out.
> Code wise LGTM,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
OK thanks,
Tony