Re: [PATCH v1 2/6] dt-bindings: hypervisor: Add binding for MediaTek GenieZone hypervisor

[Yi-De Wu (吳一德)]

On Thu, 2023-04-13 at 15:05 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 13/04/2023 11:07, Yi-De Wu wrote:
> > From: "Yingshiuan Pan" <yingshiuan.pan@xxxxxxxxxxxx>
> > 
> > Add documentation for GenieZone(gzvm) node. This node informs gzvm
> > driver to start probing if geniezone hypervisor is available and
> 
> Subject: drop second/last, redundant "binding for". The "dt-bindings"
> prefix is already stating that these are bindings.
> 
Thank you for the review comments. We would remove the "binding for"
wording in the subject on the next version.

> > able to do virtual machine operations.
> > 
> > Signed-off-by: Yingshiuan Pan <yingshiuan.pan@xxxxxxxxxxxx>
> > Signed-off-by: Yi-De Wu <yi-de.wu@xxxxxxxxxxxx>
> > ---
> >  .../bindings/hypervisor/mediatek,gzvm.yaml    | 30
> > +++++++++++++++++++
> >  1 file changed, 30 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/hypervisor/mediatek,gzvm.yaml
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/hypervisor/mediatek,gzvm.yaml
> > b/Documentation/devicetree/bindings/hypervisor/mediatek,gzvm.yaml
> > new file mode 100644
> > index 000000000000..35e1e5b18e47
> > --- /dev/null
> > +++
> > b/Documentation/devicetree/bindings/hypervisor/mediatek,gzvm.yaml
> > @@ -0,0 +1,30 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: 
> > https://urldefense.com/v3/__http://devicetree.org/schemas/hypervisor/mediatek,gzvm.yaml*__;Iw!!CTRNKA9wMg0ARbw!lp4d4WBp26cpOeEGcKn_aHcNGfyl1Y--BYzfR8oR_0Xzr9TLvUELfOQAAdqHlLIOra1W_QdjVSJv0-HMpLesJmA3TPJSag$
> > +$schema: 
> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!lp4d4WBp26cpOeEGcKn_aHcNGfyl1Y--BYzfR8oR_0Xzr9TLvUELfOQAAdqHlLIOra1W_QdjVSJv0-HMpLesJmDSXil_Qw$
> > +
> > +title: MediaTek GenieZone hypervisor
> > +
> > +maintainers:
> > +  - Yingshiuan Pan <yingshiuan.pan@xxxxxxxxxxxx>
> > +
> > +description:
> > +  GenieZone is MediaTek proprietary hypervisor. This device node
> > informs its
> > +  driver, gzvm, to probe if platform supports running virtual
> > machines.
> 
> Do not describe Linux, we all know how driver binding works, but
> hardware/firmware/hypervisor.
> 
Noted. We would enhance the description on next version.

> I don't know if we actually want to support proprietary hypervisors.
> There can be hundreds of them, one per each SoC manufacturer, and
> they
> can come with many ridiculous ideas.
> 
MediaTek, as a partner of Android, our GenieZone hypervisor has been
one of the backend options under Android Virtualization Framework(AVF)
now.
Thus, we'd like to donate these patches for better supporting the
Linux/Android ecosystem.

Reference link: https://crosvm.dev/book/hypervisors.html#geniezone 

> > +
> > +properties:
> > +  compatible:
> > +    const: mediatek,gzvm
> > +
> > +required:
> > +  - compatible
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    hypervisor {
> > +        compatible = "mediatek,gzvm";
> > +        status = "okay";
> 
> Drop status.
> 
> Best regards,
> Krzysztof
>