Re: [PATCH 2/3] arm64: dts: rockchip: Use generic name for es8316 on rk3588-rock-5b

From: Krzysztof Kozlowski
Date: Fri Apr 14 2023 - 07:28:47 EST


On 14/04/2023 12:53, Cristian Ciocaltea wrote:
> On 4/14/23 13:26, Krzysztof Kozlowski wrote:
>> On 14/04/2023 11:34, Cristian Ciocaltea wrote:
>>> Use generic 'audio-codec' name for es8316 node on Rock 5B board.
>>>
>>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx>
>>> ---
>>> arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>>> index 62750beb12aa..8cc97d146a73 100644
>>> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>>> @@ -72,7 +72,7 @@ hym8563: rtc@51 {
>>> &i2c7 {
>>> status = "okay";
>>>
>>> - es8316: es8316@11 {
>>> + es8316: audio-codec@11 {
>>
>> This is a trivial change. Fix all instances in all subarch/platform DTS.
>> Not board-per-board.
>
> Looks like only the rockchip DTS are affected, but not quite sure how to
> proceed in the case of 'es8316: codec@', should I change them to
> 'es8316: audio-codec@' as well?
>
> arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts: es8316: es8316@11 {

No, fix only this.

Best regards,
Krzysztof