Re: [PATCH] phy: mediatek: fix returning garbage

[Matthias Brugger]

On 14/04/2023 17:43, Matthias Brugger wrote:
> On 14/04/2023 14:22, Tom Rix wrote:
> > clang reports
> > drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable
> >    'ret' is uninitialized when used here [-Werror,-Wuninitialized]
> >          if (ret)
> >              ^~~
> > ret should have been set by the preceding call to mtk_hdmi_pll_set_hw.
> >
> > Fixes: 45810d486bb4 ("phy: mediatek: add support for phy-mtk-hdmi-mt8195")
> > Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
>
> Reviewed-by: Matthias Brugger <matthias.bgg@xxxxxxxxx>

Please also add
Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>

see CA+G9fYu4o0-ZKSthi7kdCjz_kFazZS-rn17Z2NPz3=1Oayr9cw@xxxxxxxxxxxxxx

Regards,
Matthias

> > ---
> >   drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c 
> > b/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c
> > index abfc077fb0a8..c63294e451d6 100644
> > --- a/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c
> > +++ b/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c
> > @@ -292,9 +292,9 @@ static int mtk_hdmi_pll_calc(struct mtk_hdmi_phy 
> > *hdmi_phy, struct clk_hw *hw,
> >       if (!(digital_div <= 32 && digital_div >= 1))
> >           return -EINVAL;
> > -    mtk_hdmi_pll_set_hw(hw, PLL_PREDIV, fbkdiv_high, fbkdiv_low,
> > -                PLL_FBKDIV_HS3, posdiv1, posdiv2, txprediv,
> > -                txposdiv, digital_div);
> > +    ret = mtk_hdmi_pll_set_hw(hw, PLL_PREDIV, fbkdiv_high, fbkdiv_low,
> > +                  PLL_FBKDIV_HS3, posdiv1, posdiv2, txprediv,
> > +                  txposdiv, digital_div);
> >       if (ret)
> >           return -EINVAL;