RE: [PATCH v9 2/2] i2c: designware: Add doorbell support for Mendocino

[Limonciello, Mario]

[Public]



> -----Original Message-----
> From: kernel test robot <lkp@xxxxxxxxx>
> Sent: Friday, April 14, 2023 11:50
> To: Limonciello, Mario <Mario.Limonciello@xxxxxxx>; Herbert Xu
> <herbert@xxxxxxxxxxxxxxxxxxx>; Jarkko Nikula
> <jarkko.nikula@xxxxxxxxxxxxxxx>; Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx>; Mika Westerberg
> <mika.westerberg@xxxxxxxxxxxxxxx>; Jan Dabros <jsd@xxxxxxxxxxxx>
> Cc: oe-kbuild-all@xxxxxxxxxxxxxxx; linux-crypto@xxxxxxxxxxxxxxx; Limonciello,
> Mario <Mario.Limonciello@xxxxxxx>; Mark Hasemeyer
> <markhas@xxxxxxxxxxxx>; Wolfram Sang <wsa-dev@sang-
> engineering.com>; linux-i2c@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v9 2/2] i2c: designware: Add doorbell support for
> Mendocino
> 
> Hi Mario,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on next-20230413]
> [cannot apply to wsa/i2c/for-next linus/master v6.3-rc6 v6.3-rc5 v6.3-rc4
> v6.3-rc6]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/i2c-
> designware-Use-PCI-PSP-driver-for-communication/20230414-224238
> patch link:    https://lore.kernel.org/r/20230414144008.836-3-
> mario.limonciello%40amd.com
> patch subject: [PATCH v9 2/2] i2c: designware: Add doorbell support for
> Mendocino
> config: x86_64-allyesconfig (https://download.01.org/0day-
> ci/archive/20230415/202304150012.IieZ4vzl-lkp@xxxxxxxxx/config)
> compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
> reproduce (this is a W=1 build):
>         # https://github.com/intel-lab-
> lkp/linux/commit/a8ae7845f0c3fcb46f4c37508838fed08dae7eec
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Mario-Limonciello/i2c-designware-Use-
> PCI-PSP-driver-for-communication/20230414-224238
>         git checkout a8ae7845f0c3fcb46f4c37508838fed08dae7eec
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         make W=1 O=build_dir ARCH=x86_64 olddefconfig
>         make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/i2c/
> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Link: https://lore.kernel.org/oe-kbuild-all/202304150012.IieZ4vzl-
> lkp@xxxxxxxxx/
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/i2c/busses/i2c-designware-amdpsp.c: In function
> 'psp_send_i2c_req_doorbell':
> >> drivers/i2c/busses/i2c-designware-amdpsp.c:82:15: error: too many
> arguments to function 'psp_ring_platform_doorbell'
>       82 |         ret = psp_ring_platform_doorbell(req->type, &req->hdr.status);
>          |               ^~~~~~~~~~~~~~~~~~~~~~~~~~
>    In file included from drivers/i2c/busses/i2c-designware-amdpsp.c:5:
>    include/linux/psp-platform-access.h:51:5: note: declared here
>       51 | int psp_ring_platform_doorbell(int msg);
>          |     ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> 
> vim +/psp_ring_platform_doorbell +82 drivers/i2c/busses/i2c-designware-
> amdpsp.c
> 
>     77
>     78	static int psp_send_i2c_req_doorbell(struct psp_i2c_req *req)
>     79	{
>     80		int ret;
>     81
>   > 82		ret = psp_ring_platform_doorbell(req->type, &req-
> >hdr.status);
>     83		if (ret == -EIO)
>     84			return check_i2c_req_sts(req);
>     85
>     86		return ret;
>     87	}
>     88
> 
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests

FYI - this failure is because it was tested across wrong tree.  I didn't use
a base commit so it guessed.

Thanks,