Re: [PATCH] hwmon: (k10temp): Check range scale when CUR_TEMP register is read-write
From: Guenter Roeck
Date: Sun Apr 16 2023 - 10:35:54 EST
On Thu, Apr 13, 2023 at 04:39:58PM -0500, Babu Moger wrote:
> From: Babu Moger <Babu.Moger@xxxxxxx>
>
> Spec says, when CUR_TEMP_TJ_SEL == 3 and CUR_TEMP_RANGE_SEL == 0,
> it should use RangeUnadjusted is 0, which is (CurTmp*0.125 -49) C. The
> CUR_TEMP register is read-write when CUR_TEMP_TJ_SEL == 3 (bit 17-16).
>
> Add the check to detect it.
>
> Sensors command's output before the patch.
> $sensors
> k10temp-pci-00c3
> Adapter: PCI adapter
> Tctl: +76.6°C <- Wrong value
> Tccd1: +26.5°C
> Tccd2: +27.5°C
> Tccd3: +27.2°C
> Tccd4: +27.5°C
> Tccd5: +26.0°C
> Tccd6: +26.2°C
> Tccd7: +25.0°C
> Tccd8: +26.5°C
>
> Sensors command's output after the patch.
> $sensors
> k10temp-pci-00c3
> Adapter: PCI adapter
> Tctl: +28.8°C <- corrected value
> Tccd1: +27.5°C
> Tccd2: +28.5°C
> Tccd3: +28.5°C
> Tccd4: +28.5°C
> Tccd5: +27.0°C
> Tccd6: +27.5°C
> Tccd7: +27.0°C
> Tccd8: +27.5°C
>
> Signed-off-by: Babu Moger <babu.moger@xxxxxxx>
Applied. Please update your e-mail address configuration to avoid the
following checkpatch message.
CHECK: From:/Signed-off-by: email comments mismatch: 'From: Babu Moger <Babu.Moger@xxxxxxx>' != 'Signed-off-by: Babu Moger <babu.moger@xxxxxxx>'
Thanks,
Guenter