Re: [PATCH net-next v2] net: wwan: Expose secondary AT port on DATA1

[Stephan Gerhold]

On Mon, Apr 17, 2023 at 08:07:24AM +0200, Jaime Breva via B4 Relay wrote:
> From: Jaime Breva <jbreva@xxxxxxxxxxxxxxxx>
> 
> Our use-case needs two AT ports available:
> One for running a ppp daemon, and another one for management
> 
> This patch enables a second AT port on DATA1
> 
> Signed-off-by: Jaime Breva <jbreva@xxxxxxxxxxxxxxxx>

For future patch resubmissions please pick up already given review tags
when you resend new versions (b4 trailers can help you with this).

Acked-by: Stephan Gerhold <stephan@xxxxxxxxxxx>

Thanks,
Stephan

> ---
> Changes in v2:
> - Modified subject prefix to be netdev list compliant
> - Link to v1: https://lore.kernel.org/r/20230414-rpmsg-wwan-secondary-at-port-v1-1-6d7307527911@xxxxxxxxxxxxxxxx
> ---
>  drivers/net/wwan/rpmsg_wwan_ctrl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wwan/rpmsg_wwan_ctrl.c b/drivers/net/wwan/rpmsg_wwan_ctrl.c
> index 31c24420ab2e..e964bdeea2b3 100644
> --- a/drivers/net/wwan/rpmsg_wwan_ctrl.c
> +++ b/drivers/net/wwan/rpmsg_wwan_ctrl.c
> @@ -149,6 +149,7 @@ static const struct rpmsg_device_id rpmsg_wwan_ctrl_id_table[] = {
>  	/* RPMSG channels for Qualcomm SoCs with integrated modem */
>  	{ .name = "DATA5_CNTL", .driver_data = WWAN_PORT_QMI },
>  	{ .name = "DATA4", .driver_data = WWAN_PORT_AT },
> +	{ .name = "DATA1", .driver_data = WWAN_PORT_AT },
>  	{},
>  };
>  MODULE_DEVICE_TABLE(rpmsg, rpmsg_wwan_ctrl_id_table);
> 
> ---
> base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c
> change-id: 20230414-rpmsg-wwan-secondary-at-port-db72a66ce74a
> 
> Best regards,
> -- 
> Jaime Breva <jbreva@xxxxxxxxxxxxxxxx>
>