Re: [PATCH v2 1/5] arm64: dts: ti: k3-j784s4-main: Add system controller and SERDES lane mux

[Jayesh Choudhary]

Hi Vignesh,

On 17/04/23 10:07, Vignesh Raghavendra wrote:
> Hi Jayesh
>
> On 14/04/23 20:45, Jayesh Choudhary wrote:
> > From: Siddharth Vadapalli <s-vadapalli@xxxxxx>
> >
> > The system controller node manages the CTRL_MMR0 region.
> > Add serdes_ln_ctrl node which is used for controlling the SERDES lane mux.
> >
> > Signed-off-by: Siddharth Vadapalli <s-vadapalli@xxxxxx>
> > Signed-off-by: Jayesh Choudhary <j-choudhary@xxxxxx>
> > ---
> >   arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 22 ++++++++++++++++++++++
> >   1 file changed, 22 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> > index e9169eb358c1..344f4ffa0b82 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> > @@ -5,6 +5,9 @@
> >    * Copyright (C) 2022 Texas Instruments Incorporated - https://www.ti.com/
> >    */
> >   
> > +#include <dt-bindings/mux/mux.h>
> > +#include <dt-bindings/mux/ti-serdes.h>
> > +
> >   &cbass_main {
> >   	msmc_ram: sram@70000000 {
> >   		compatible = "mmio-sram";
> > @@ -26,6 +29,25 @@ l3cache-sram@200000 {
> >   		};
> >   	};
> >   
> > +	scm_conf: scm-conf@100000 {
>
> generic node name please: "syscon@"

Okay.

> > +		compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";
> > +		reg = <0x00 0x00100000 0x00 0x1c000>;
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		ranges = <0x00 0x00 0x00100000 0x1c000>;
> > +
> > +		serdes_ln_ctrl: mux-controller@4080 {
>
> Either add reg property or replace @ with -

Will use '-'.

> Run make with W=12 to catch such errors.

Okay. Will do.

Thanks.

[...]