Re: [PATCH 1/2] wifi: brcmfmac: Demote vendor-specific attach/detach messages to info

[Hector Martin]

On 16/04/2023 21.46, Greg KH wrote:
> On Sun, Apr 16, 2023 at 09:42:17PM +0900, Hector Martin wrote:
>> People are getting spooked by brcmfmac errors on their boot console.
>> There's no reason for these messages to be errors.
>>
>> Cc: stable@xxxxxxxxxxxxxxx
>> Fixes: d6a5c562214f ("wifi: brcmfmac: add support for vendor-specific firmware api")
>> Signed-off-by: Hector Martin <marcan@xxxxxxxxx>
>> ---
>>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c | 4 ++--
>>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c | 4 ++--
>>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c | 4 ++--
>>  3 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c
>> index ac3a36fa3640..c83bc435b257 100644
>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c
>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c
>> @@ -12,13 +12,13 @@
>>  
>>  static int brcmf_bca_attach(struct brcmf_pub *drvr)
>>  {
>> -	pr_err("%s: executing\n", __func__);
>> +	pr_info("%s: executing\n", __func__);
> 
> Why are these here at all?  Please just remove these entirely, you can
> get this information normally with ftrace.
> 
> Or, just delete these functions, why have empty ones at all?

This is a new WIP code path that Arend introduced which currently
deliberately does nothing (but is intended to hold firmware vendor
specific init in the future). So we can just drop the messages, but I
don't think we want to remove the code entirely.

- Hector