Re: [PATCH] ACPI: video: Add backlight=native DMI quirk for Lenovo Ideapad Z470

From: Rafael J. Wysocki
Date: Mon Apr 17 2023 - 07:42:44 EST


On Mon, Apr 17, 2023 at 12:48 PM Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx> wrote:
>
> From: Hans de Goede <hdegoede@xxxxxxxxxx>
>
> The Lenovo Ideapad Z470 predates Windows 8, so it defaults to using
> acpi_video for backlight control. But this is not functional on this
> model.
>
> Add a DMI quirk to use the native backlight interface which works.
>
> Link: https://bugzilla.suse.com/show_bug.cgi?id=1208724
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx>
> Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

Hans, can you please give your S-o-b for this one?

> ---
> drivers/acpi/video_detect.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index 69ef2d9710c2..af5cea005f54 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -459,6 +459,15 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
> DMI_MATCH(DMI_BOARD_NAME, "Lenovo IdeaPad S405"),
> },
> },
> + {
> + /* https://bugzilla.suse.com/show_bug.cgi?id=1208724 */
> + .callback = video_detect_force_native,
> + /* Lenovo Ideapad Z470 */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Z470"),
> + },
> + },
> {
> /* https://bugzilla.redhat.com/show_bug.cgi?id=1187004 */
> .callback = video_detect_force_native,
> --
> 2.40.0
>