RE: [PATCH v2 3/8] dt-bindings: power: supply: max77658: Add ADI MAX77654/58/59 Charger

[Arslanbenzer, Zeynep]

>On 22/03/2023 06:56, Zeynep Arslanbenzer wrote:
>> Add ADI MAX77654/MAX77658/MAX77659 power supply devicetree document.
>> 
>> Signed-off-by: Nurettin Bolucu <Nurettin.Bolucu@xxxxxxxxxx>>
>> Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@xxxxxxxxxx>>
>> ---
>>  .../power/supply/adi,max77658-charger.yaml    | 65 +++++++++++++++++++
>>  1 file changed, 65 insertions(+)
>>  create mode 100644 
>> Documentation/devicetree/bindings/power/supply/adi,max77658-charger.ya
>> ml
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/power/supply/adi,max77658-charger.
>> yaml 
>> b/Documentation/devicetree/bindings/power/supply/adi,max77658-charger.
>> yaml
>> new file mode 100644
>> index 000000000000..f140abab969c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/power/supply/adi,max77658-char
>> +++ ger.yaml
>> @@ -0,0 +1,65 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
>> +---
>> +$id: 
>> +https://urldefense.com/v3/__http://devicetree.org/schemas/power/suppl
>> +y/adi,max77658-charger.yaml*__;Iw!!A3Ni8CS0y2Y!6-xzReMH0We2Hv87KO_HBQ
>> +bP0IddfulmvzWOzSsxmA6TqV_V2Mo6KyJ5H6hAqZGFeGOE4UUIy9Dv-ZNUon6VJR3ITTw
>> +OLmNnuOb-$
>> +$schema: 
>> +https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.y
>> +aml*__;Iw!!A3Ni8CS0y2Y!6-xzReMH0We2Hv87KO_HBQbP0IddfulmvzWOzSsxmA6TqV
>> +_V2Mo6KyJ5H6hAqZGFeGOE4UUIy9Dv-ZNUon6VJR3ITTwOLk8moz89$
>> +
>> +title: Battery charger for MAX77658 PMICs family from ADI.
>
>This is a friendly reminder during the review process.
>
>It seems my previous comments were not fully addressed. Actually you ignored all of them. Maybe my feedback got lost between the quotes, maybe you just forgot to >apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them.
>
>Thank you.
>
>Best regards,
>Krzysztof

Hi Krzysztof,

Thank you for your review. I actually tried to complete most of them but I may have misunderstood some of them. I'm sorry about that. I will be more careful in future versions.

Best regards,
Zeynep