Re: [PATCH v2 2/7] dt-bindings: soundwire: qcom: add 16-bit sample interval
From: Krzysztof Kozlowski
Date: Mon Apr 17 2023 - 10:18:06 EST
On 13/04/2023 13:12, Srinivas Kandagatla wrote:
>>>> + qcom,ports-sinterval:
>>>> + $ref: /schemas/types.yaml#/definitions/uint32-array
>>>
>>> Should this not be ref: /schemas/types.yaml#/definitions/uint16-array ?
>>
>> Same answer as for Rob:
>>
>> Because I am afraid it will grow in next version to 24 or 32 bits. I can
>> change easily maximum, but if I put here uint16-array, all DTS will have
>> /bytes 16/ annotation.
>>
> As per MiPi Specs the sample Interval is an integer in the range 2 to
> 65535. I don't see a value in making this u32, other than adding some
> confusion by deviating from specs.
Hm, in such case I'll make it uint16.
Best regards,
Krzysztof