RE: [PATCH linux-next 1/3] selftests: net: udpgso_bench_rx: Fix verifty exceptions

From: Willem de Bruijn
Date: Mon Apr 17 2023 - 11:16:10 EST


Yang Yang wrote:
> From: Zhang Yunkai (CGEL ZTE) <zhang.yunkai@xxxxxxxxxx>
>
> The verification function of this test case is likely to encounter the
> following error, which may confuse users.
>
> Executing the following command fails:
> bash# udpgso_bench_tx -l 4 -4 -D "$DST"
> bash# udpgso_bench_tx -l 4 -4 -D "$DST" -S 0
> bash# udpgso_bench_rx -4 -G -S 1472 -v

Why are you running two senders concurrently? The test is not intended
to handle that case.

> udpgso_bench_rx: data[1472]: len 2944, a(97) != q(113)
>
> This is because the sending buffers are not aligned by 26 bytes, and the
> GRO is not merged sequentially, and the receiver does not judge this
> situation. We do the validation after the data is split at the receiving
> end, just as the application actually uses this feature.
>
> Signed-off-by: Zhang Yunkai (CGEL ZTE) <zhang.yunkai@xxxxxxxxxx>
> Reviewed-by: xu xin (CGEL ZTE) <xu.xin16@xxxxxxxxxx>
> Reviewed-by: Yang Yang (CGEL ZTE) <yang.yang29@xxxxxxxxxx>
> Cc: Xuexin Jiang (CGEL ZTE) <jiang.xuexin@xxxxxxxxxx>