Re: [PATCH v2 1/2] dt-bindings: net: wireless: ath9k: document endian check

[Álvaro Fernández Rojas]

El lun, 17 abr 2023 a las 9:20, Krzysztof Kozlowski
(<krzk@xxxxxxxxxx>) escribió:
>
> On 17/04/2023 07:35, Álvaro Fernández Rojas wrote:
> > Document new endian check flag to allow checking the endianness of EEPROM and
> > swap its values if needed.
> >
> > Signed-off-by: Álvaro Fernández Rojas <noltari@xxxxxxxxx>
>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC.  It might happen, that command when run on an older
> kernel, gives you outdated entries.  Therefore please be sure you base
> your patches on recent Linux kernel.

I forgot to get the updated list for v2, sorry for that!

>
> You missed the lists so this won't be tested. Resend following Linux
> kernel submission process.

Looks like we will need v3 anyway, so I'll get all the maintainers in
the next version.

>
>
> > ---
> >  .../devicetree/bindings/net/wireless/qca,ath9k.yaml          | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> > index 0e5412cff2bc..ff9ca5e3674b 100644
> > --- a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> > +++ b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> > @@ -44,6 +44,11 @@ properties:
> >
> >    ieee80211-freq-limit: true
> >
> > +  qca,endian-check:
> > +    $ref: /schemas/types.yaml#/definitions/flag
> > +    description:
> > +      Indicates that the EEPROM endianness should be checked
>
> Does not look like hardware property. Do not instruct what driver should
> or should not do. It's not the purpose of DT.
>
>
> Best regards,
> Krzysztof
>