Re: [PATCH] dt-bindings: phy: qmp-ufs: fix clock and clock-names for sa8775p

From: Krzysztof Kozlowski
Date: Tue Apr 18 2023 - 03:30:49 EST


On 17/04/2023 15:05, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> We must set *minItems* to 3, not maxItems as this platform requires
> exactly three clocks and maxItems is already set to 3 globally.
>
> Fixes: e5796a9cdf73 ("dt-bindings: phy: qmp-ufs: describe the UFS PHY for sa8775p")

Your change makes the code easier to read (more obvious), so I am okay
with the change, but I am not okay with commit msg and Fixes tag. Issue
is described inaccurately. There is nothing to fix here, because
original code was correct.

maxItems:3 in implies minItems:3, thus everything worked as should.

Feel free to re-phrase the commit msg and remove the Fixes tag.

> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> ---

Best regards,
Krzysztof