Re: [PATCH RESEND] sh: sq: Use the bitmap API when applicable

From: John Paul Adrian Glaubitz
Date: Tue Apr 18 2023 - 05:43:01 EST


Hi Dan!

On Tue, 2023-04-18 at 12:39 +0300, Dan Carpenter wrote:
> On Tue, Apr 18, 2023 at 10:30:01AM +0300, Dan Carpenter wrote:
> > I have some unpublished Smatch stuff which tries to track "variable x
> > is in terms of bit units or byte units etc." I will try to make a
> > static checker rule for this.
>
> Attached. It prints a warning like this:
>
> drivers/net/ethernet/broadcom/cnic.c:667 cnic_init_id_tbl() warn: allocating units of longs instead of bytes 'test_var'
>
> I'll test it out tonight.

Nice job, thanks for creating this very handy script!

Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913