Re: [PATCH v2] docs: f2fs: specify extent cache for read explicitly
From: Jonathan Corbet
Date: Tue Apr 18 2023 - 09:47:50 EST
Bagas Sanjaya <bagasdotme@xxxxxxxxx> writes:
> On 4/17/23 11:41, Yangtao Li wrote:
>> Let's descrbie it's read extent cache.
>
> "Clarify the fact that extent_cache and noextent_cache toggle read
> extent cache on or off."
Please stop nit-picking patches. This is good enough, though I might
fix the "describe" typo on the way in.
>> -extent_cache Enable an extent cache based on rb-tree, it can cache
>> - as many as extent which map between contiguous logical
>> +extent_cache Enable a read extent cache based on rb-tree, it can cache
> "... . It can cache ..."
Bagas. Enough. Seriously.
>> noinline_data Disable the inline data feature, inline data feature is
>> enabled by default.
>
> "Disable inline data feature, for which the feature is enabled by
> default." (submit as separate patch).
And please stop trying to make additional work for others. If you want
to improve something, submit a patch yourself.
jon