Quoting 周师德 (2023-04-13 19:02:19)
I see two patches to the same driver from the same university on the
-----原始邮件-----What do you mean by "coordinating with each other"?
发件人: "Stephen Boyd" <sboyd@xxxxxxxxxx>
发送时间: 2023-04-14 03:06:59 (星期五)
收件人: "Abel Vesa" <abelvesa@xxxxxxxxxx>, "Bai Ping" <ping.bai@xxxxxxx>, "Fabio Estevam" <festevam@xxxxxxxxx>, "Michael Turquette" <mturquette@xxxxxxxxxxxx>, "NXP Linux Team" <linux-imx@xxxxxxx>, "Peng Fan" <peng.fan@xxxxxxx>, "Pengutronix Kernel Team" <kernel@xxxxxxxxxxxxxx>, "Sascha Hauer" <s.hauer@xxxxxxxxxxxxxx>, "Shawn Guo" <shawnguo@xxxxxxxxxx>, "Zhou Shide" <u201911681@xxxxxxxxxxx>
抄送: hust-os-kernel-patches@xxxxxxxxxxxxxxxx, "Zhou Shide" <u201911681@xxxxxxxxxxx>, linux-clk@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, "Hao Luo" <m202171776@xxxxxxxxxxx>
主题: Re: [PATCH] clk: imx: clk-imx8mm: fix memory leak issue in 'imx8mm_clocks_probe'
Quoting Zhou Shide (2023-04-12 20:24:39)
The function imx8mm_clocks_probe() has two main issues:And you're not coordinating with each other?
- The of_iomap() function may cause a memory leak.
- Memory allocated for 'clk_hw_data' may not be freed properly
in some paths.
To fix these issues, this commit replaces the use of of_iomap()
with devm_of_iomap() and replaces kzalloc() with devm_kzalloc().
This ensures that all memory is properly managed and automatically
freed when the device is removed.
In addition, when devm_of_iomap() allocates memory with an error,
it will first jump to label "unregister_hws" and
then return PTR_ ERR(base).
Fixes: 9c71f9ea35d7 ("clk: imx: imx8mm: Switch to clk_hw based API")
Fixes: ba5625c3e272 ("clk: imx: Add clock driver support for imx8mm")
Signed-off-by: Zhou Shide <u201911681@xxxxxxxxxxx>
---
The issue is discovered by static analysis, and the patch is not tested yet.
list. Preferably you coordinate and decide who will fix what smatch
warnings.