Re: [PATCH] Revert "media: mediatek: vcodec: Fix bitstream crop information error"

[AngeloGioacchino Del Regno]

Il 18/04/23 23:50, Nícolas F. R. A. Prado ha scritto:
> This reverts commit cd61f3c6794bea2b717fe6083ca2ad189db75418. That
> commit's purpose was to prevent the padding from being decoded when
> userspace didn't set a selection, relying on the default one.
>
> However, as described in the Step 6 of the Initialization procedure for
> the Memory-to-Memory Stateful Video Encoder Interface [1]:
>
> "Set the visible resolution for the stream metadata via
> VIDIOC_S_SELECTION() on the OUTPUT queue if it is desired to be
> different than the full OUTPUT resolution."
>
> And from the Note:
>
> "To avoid encoding the padding, the client needs to explicitly configure
> this selection target"
>
> Hence the behavior in the original commit doesn't follow the interface
> and needs to be reverted.
>
> This fixes the following v4l2-compliance failure observed on
> mt8192-asurada-spherion:
>
> 		fail: v4l2-test-formats.cpp(924): sel.r.width != fmt.g_width()
> 	test VIDIOC_S_FMT: FAIL
>
> [1] https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/dev-encoder.html#initialization
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>

On MT8192 Asurada Spherion and MT8195 Cherry Tomato:

Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>