Re: [PATCH 2/2] drm/amdgpu: Fix integer overflow in amdgpu_cs_pass1

From: kernel test robot
Date: Wed Apr 19 2023 - 06:45:05 EST

Next message: Sagi Grimberg: "Re: [PATCH blktests v2 2/2] nvme-rc: Cleanup fc resource before module unloading"
Previous message: Fei Shao: "Re: [PATCH 1/2] dt-bindings: input: goodix: Add powered-in-suspend property"
In reply to: Christian König: "Re: [PATCH 2/2] drm/amdgpu: Fix integer overflow in amdgpu_cs_pass1"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi hackyzh002,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on linus/master v6.3-rc7 next-20230418]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/hackyzh002/drm-amdgpu-Fix-integer-overflow-in-amdgpu_cs_pass1/20230419-125344
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link: https://lore.kernel.org/r/20230419045157.69829-1-hackyzh002%40gmail.com
patch subject: [PATCH 2/2] drm/amdgpu: Fix integer overflow in amdgpu_cs_pass1
config: arm64-buildonly-randconfig-r004-20230416 (https://download.01.org/0day-ci/archive/20230419/202304191814.1O8ppodq-lkp@xxxxxxxxx/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 437b7602e4a998220871de78afcb020b9c14a661)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/c4a89869bcb6b68ad0e1eed0dd4f18c8cc7fbfc5
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review hackyzh002/drm-amdgpu-Fix-integer-overflow-in-amdgpu_cs_pass1/20230419-125344
git checkout c4a89869bcb6b68ad0e1eed0dd4f18c8cc7fbfc5
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/gpu/drm/amd/amdgpu/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202304191814.1O8ppodq-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:195:11: error: cannot combine with previous 'type-name' declaration specifier
uint64_t int size;
^
1 error generated.

vim +195 drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c

184
185 /* Copy the data from userspace and go over it the first time */
186 static int amdgpu_cs_pass1(struct amdgpu_cs_parser *p,
187 union drm_amdgpu_cs *cs)
188 {
189 struct amdgpu_fpriv *fpriv = p->filp->driver_priv;
190 unsigned int num_ibs[AMDGPU_CS_GANG_SIZE] = { };
191 struct amdgpu_vm *vm = &fpriv->vm;
192 uint64_t *chunk_array_user;
193 uint64_t *chunk_array;
194 uint32_t uf_offset = 0;
> 195 uint64_t int size;
196 int ret;
197 int i;
198
199 chunk_array = kvmalloc_array(cs->in.num_chunks, sizeof(uint64_t),
200 GFP_KERNEL);
201 if (!chunk_array)
202 return -ENOMEM;
203
204 /* get chunks */
205 chunk_array_user = u64_to_user_ptr(cs->in.chunks);
206 if (copy_from_user(chunk_array, chunk_array_user,
207 sizeof(uint64_t)*cs->in.num_chunks)) {
208 ret = -EFAULT;
209 goto free_chunk;
210 }
211
212 p->nchunks = cs->in.num_chunks;
213 p->chunks = kvmalloc_array(p->nchunks, sizeof(struct amdgpu_cs_chunk),
214 GFP_KERNEL);
215 if (!p->chunks) {
216 ret = -ENOMEM;
217 goto free_chunk;
218 }
219
220 for (i = 0; i < p->nchunks; i++) {
221 struct drm_amdgpu_cs_chunk __user **chunk_ptr = NULL;
222 struct drm_amdgpu_cs_chunk user_chunk;
223 uint32_t __user *cdata;
224
225 chunk_ptr = u64_to_user_ptr(chunk_array[i]);
226 if (copy_from_user(&user_chunk, chunk_ptr,
227 sizeof(struct drm_amdgpu_cs_chunk))) {
228 ret = -EFAULT;
229 i--;
230 goto free_partial_kdata;
231 }
232 p->chunks[i].chunk_id = user_chunk.chunk_id;
233 p->chunks[i].length_dw = user_chunk.length_dw;
234
235 size = p->chunks[i].length_dw;
236 cdata = u64_to_user_ptr(user_chunk.chunk_data);
237
238 p->chunks[i].kdata = kvcalloc(size, sizeof(uint32_t),
239 GFP_KERNEL);
240 if (p->chunks[i].kdata == NULL) {
241 ret = -ENOMEM;
242 i--;
243 goto free_partial_kdata;
244 }
245 size *= sizeof(uint32_t);
246 if (copy_from_user(p->chunks[i].kdata, cdata, size)) {
247 ret = -EFAULT;
248 goto free_partial_kdata;
249 }
250
251 /* Assume the worst on the following checks */
252 ret = -EINVAL;
253 switch (p->chunks[i].chunk_id) {
254 case AMDGPU_CHUNK_ID_IB:
255 if (size < sizeof(struct drm_amdgpu_cs_chunk_ib))
256 goto free_partial_kdata;
257
258 ret = amdgpu_cs_p1_ib(p, p->chunks[i].kdata, num_ibs);
259 if (ret)
260 goto free_partial_kdata;
261 break;
262
263 case AMDGPU_CHUNK_ID_FENCE:
264 if (size < sizeof(struct drm_amdgpu_cs_chunk_fence))
265 goto free_partial_kdata;
266
267 ret = amdgpu_cs_p1_user_fence(p, p->chunks[i].kdata,
268 &uf_offset);
269 if (ret)
270 goto free_partial_kdata;
271 break;
272
273 case AMDGPU_CHUNK_ID_BO_HANDLES:
274 if (size < sizeof(struct drm_amdgpu_bo_list_in))
275 goto free_partial_kdata;
276
277 ret = amdgpu_cs_p1_bo_handles(p, p->chunks[i].kdata);
278 if (ret)
279 goto free_partial_kdata;
280 break;
281
282 case AMDGPU_CHUNK_ID_DEPENDENCIES:
283 case AMDGPU_CHUNK_ID_SYNCOBJ_IN:
284 case AMDGPU_CHUNK_ID_SYNCOBJ_OUT:
285 case AMDGPU_CHUNK_ID_SCHEDULED_DEPENDENCIES:
286 case AMDGPU_CHUNK_ID_SYNCOBJ_TIMELINE_WAIT:
287 case AMDGPU_CHUNK_ID_SYNCOBJ_TIMELINE_SIGNAL:
288 break;
289
290 default:
291 goto free_partial_kdata;
292 }
293 }
294
295 if (!p->gang_size) {
296 ret = -EINVAL;
297 goto free_partial_kdata;
298 }
299
300 for (i = 0; i < p->gang_size; ++i) {
301 ret = amdgpu_job_alloc(p->adev, vm, p->entities[i], vm,
302 num_ibs[i], &p->jobs[i]);
303 if (ret)
304 goto free_all_kdata;
305 }
306 p->gang_leader = p->jobs[p->gang_leader_idx];
307
308 if (p->ctx->vram_lost_counter != p->gang_leader->vram_lost_counter) {
309 ret = -ECANCELED;
310 goto free_all_kdata;
311 }
312
313 if (p->uf_entry.tv.bo)
314 p->gang_leader->uf_addr = uf_offset;
315 kvfree(chunk_array);
316
317 /* Use this opportunity to fill in task info for the vm */
318 amdgpu_vm_set_task_info(vm);
319
320 return 0;
321
322 free_all_kdata:
323 i = p->nchunks - 1;
324 free_partial_kdata:
325 for (; i >= 0; i--)
326 kvfree(p->chunks[i].kdata);
327 kvfree(p->chunks);
328 p->chunks = NULL;
329 p->nchunks = 0;
330 free_chunk:
331 kvfree(chunk_array);
332
333 return ret;
334 }
335

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

Next message: Sagi Grimberg: "Re: [PATCH blktests v2 2/2] nvme-rc: Cleanup fc resource before module unloading"
Previous message: Fei Shao: "Re: [PATCH 1/2] dt-bindings: input: goodix: Add powered-in-suspend property"
In reply to: Christian König: "Re: [PATCH 2/2] drm/amdgpu: Fix integer overflow in amdgpu_cs_pass1"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]