Re: [PATCH 2/2] misc: sram: Generate unique names for subpools

[Linus Walleij]

On Wed, Apr 19, 2023 at 12:38 AM Rob Herring <robh@xxxxxxxxxx> wrote:
> On Mon, Apr 17, 2023 at 09:34:57AM +0200, Linus Walleij wrote:
> > The current code will, if we do not specify unique labels
> > for the SRAM subnodes, fail to register several nodes named
> > the same.
> >
> > Example:
> >
> > sram@40020000 {
> >   (...)
> >   sram@0 {
> >     (...)
> >   };
> >   sram@1000 {
> >     (...)
> >   };
> > };
> >
> > Since the child->name in both cases will be "sram" the
> > gen_pool_create() will fail because the name is not unique.
> > So let's use of_full_node_name() instead of child->name
> > so the name is "sram@0" and "sram@1000" respectively.
> >
> > However if there are two or more SRAMs on the system
> > with subnodes named the same (that exists on the U8500)
> > then this again will not work. So catenate the top node
> > name and the subnode full name to form a string that will
> > always be unique.
>
> Use the naming platform devices use which has the translated address.
> How the addresses are defined should not affect the device name.

Aha just dev_name(&pdev->dev) I'll try this, thanks!

Yours,
Linus Walleij