Re: [RFC PATCH 1/2] arm64: amlogic: add new ARCH_AMLIPC for IPC SoC

[Neil Armstrong]

On 19/04/2023 15:14, Dmitry Rokosov wrote:
> On Wed, Apr 19, 2023 at 03:38:33PM +0800, =Xianwei Zhao wrote:
> > From: Xianwei Zhao <xianwei.zhao@xxxxxxxxxxx>
> >
> > The C series SoCs are designed for smart IP camera
> > applications, which does not belong to Meson series.
> > So, Add ARCH_AMLIPC for the new series.
> >
> > There are now multiple amlogic SoC seies supported, so group them under
> > their own menu. we can easily add new platforms there in the future.
> > Introduce ARCH_AMLOGIC to cover all Amlogic SoC series.
> >
> > No functional changes introduced.
> >
> > Signed-off-by: Xianwei Zhao <xianwei.zhao@xxxxxxxxxxx>
> > ---
> >   arch/arm64/Kconfig.platforms | 12 ++++++++++++
> >   arch/arm64/configs/defconfig |  2 ++
> >   2 files changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> > index 89a0b13b058d..bfbc817eef8f 100644
> > --- a/arch/arm64/Kconfig.platforms
> > +++ b/arch/arm64/Kconfig.platforms
> > @@ -162,12 +162,24 @@ config ARCH_MEDIATEK
> >   	  This enables support for MediaTek MT27xx, MT65xx, MT76xx
> >   	  & MT81xx ARMv8 SoCs
> >   
> > +menuconfig ARCH_AMLOGIC
> > +	bool "NXP SoC support"
>
> NXP? Did you mean "Amlogic"?
>
> > +
> > +if ARCH_AMLOGIC
> > +
> >   config ARCH_MESON
> >   	bool "Amlogic Platforms"
> >   	help
> >   	  This enables support for the arm64 based Amlogic SoCs
> >   	  such as the s905, S905X/D, S912, A113X/D or S905X/D2
> >   
> > +config ARCH_AMLIPC
>
> Do we really need a different ARCH for Amlogic IPC?
> I can imagine that it's not the Meson architecture at all.
> But maybe a better solution is just to rename ARCH_MESON to ARCH_AMLOGIC?

It should be changed treewide, and is it worth it ?

Neil

> > +	bool "Amlogic IPC Platforms"
> > +	help
> > +	  This enables support for the arm64 based Amlogic IPC SoCs
> > +	  such as the C302X, C308L
> > +endif
> > +
> >   config ARCH_MVEBU
> >   	bool "Marvell EBU SoC Family"
> >   	select ARMADA_AP806_SYSCON
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 7790ee42c68a..f231bd1723fd 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -46,7 +46,9 @@ CONFIG_ARCH_LG1K=y
> >   CONFIG_ARCH_HISI=y
> >   CONFIG_ARCH_KEEMBAY=y
> >   CONFIG_ARCH_MEDIATEK=y
> > +CONFIG_ARCH_AMLOGIC=y
> >   CONFIG_ARCH_MESON=y
> > +CONFIG_ARCH_AMLIPC=y
> >   CONFIG_ARCH_MVEBU=y
> >   CONFIG_ARCH_NXP=y
> >   CONFIG_ARCH_LAYERSCAPE=y
> > --
> > 2.37.1
> >
> >
> > _______________________________________________
> > linux-amlogic mailing list
> > linux-amlogic@xxxxxxxxxxxxxxxxxxx
> > http://lists.infradead.org/mailman/listinfo/linux-amlogic