Re: [PATCH v2] drm/display: Add missing OLED Vesa brightnesses definitions

[Harry Wentland]

On 4/11/23 20:09, Rodrigo Siqueira wrote:
> This commit adds missing luminance control registers to enable a more
> standard way (VESA) to deal with eDP luminance control.
> 
> Cc: Anthony Koo <anthony.koo@xxxxxxx>
> Cc: Iswara Negulendran <iswara.nagulendran@xxxxxxx>
> Cc: Felipe Clark <felipe.clark@xxxxxxx>
> Cc: Harry Wentland <Harry.Wentland@xxxxxxx>
> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx>

Reviewed-by: Harry Wentland <harry.wentland@xxxxxxx>

Harry

> ---
>  include/drm/display/drm_dp.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h
> index ed10e6b6f99d..7ad749423a48 100644
> --- a/include/drm/display/drm_dp.h
> +++ b/include/drm/display/drm_dp.h
> @@ -973,6 +973,7 @@
>  
>  #define DP_EDP_GENERAL_CAP_2		    0x703
>  # define DP_EDP_OVERDRIVE_ENGINE_ENABLED		(1 << 0)
> +# define DP_EDP_PANEL_LUMINANCE_CONTROL_CAPABLE		(1<<4)
>  
>  #define DP_EDP_GENERAL_CAP_3		    0x704    /* eDP 1.4 */
>  # define DP_EDP_X_REGION_CAP_MASK			(0xf << 0)
> @@ -998,6 +999,7 @@
>  # define DP_EDP_DYNAMIC_BACKLIGHT_ENABLE		(1 << 4)
>  # define DP_EDP_REGIONAL_BACKLIGHT_ENABLE		(1 << 5)
>  # define DP_EDP_UPDATE_REGION_BRIGHTNESS		(1 << 6) /* eDP 1.4 */
> +# define DP_EDP_PANEL_LUMINANCE_CONTROL_ENABLE		(1<<7)
>  
>  #define DP_EDP_BACKLIGHT_BRIGHTNESS_MSB     0x722
>  #define DP_EDP_BACKLIGHT_BRIGHTNESS_LSB     0x723
> @@ -1022,6 +1024,7 @@
>  
>  #define DP_EDP_DBC_MINIMUM_BRIGHTNESS_SET   0x732
>  #define DP_EDP_DBC_MAXIMUM_BRIGHTNESS_SET   0x733
> +#define DP_EDP_PANEL_TARGET_LUMINANCE_VALUE 0x734
>  
>  #define DP_EDP_REGIONAL_BACKLIGHT_BASE      0x740    /* eDP 1.4 */
>  #define DP_EDP_REGIONAL_BACKLIGHT_0	    0x741    /* eDP 1.4 */