Re: [PATCH v4 2/3] media: dt-bindings: ov2685: convert to dtschema
From: Luca Weiss
Date: Wed Apr 19 2023 - 11:54:37 EST
On Mittwoch, 19. April 2023 01:54:18 CEST Rob Herring wrote:
> On Thu, Mar 23, 2023 at 12:58 PM Luca Weiss <luca@xxxxxxxxx> wrote:
> > Convert the text-based dt-bindings to yaml.
> >
> > Changes from original txt:
> > * Take wording for various properties from other yaml bindings, this
> >
> > removes e.g. volt amount from schema since it isn't really relevant
> > and the datasheet is a better source.
> >
> > * Don't make reset-gpios a required property since it can be tied to
> >
> > DOVDD instead.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > Signed-off-by: Luca Weiss <luca@xxxxxxxxx>
> > ---
> >
> > .../devicetree/bindings/media/i2c/ov2685.txt | 41 ---------
> > .../devicetree/bindings/media/i2c/ovti,ov2685.yaml | 101
> > +++++++++++++++++++++ MAINTAINERS
> > | 1 +
> > 3 files changed, 102 insertions(+), 41 deletions(-)
>
> Now warning in linux-next:
>
> /builds/robherring/linux-dt/Documentation/devicetree/bindings/media/rockchip
> -isp1.example.dtb: camera@3c: port:endpoint:data-lanes: [[1]] is too short
> From schema:
> /builds/robherring/linux-dt/Documentation/devicetree/bindings/media/i2c/ovti
> ,ov2685.yaml
> /builds/robherring/linux-dt/Documentation/devicetree/bindings/media/i2c/ovt
> i,ov2685.example.dtb: camera-sensor@3c: port:endpoint:data-lanes: [[1]] is
> too short
> From schema:
> /builds/robherring/linux-dt/Documentation/devicetree/bindings/media/i2c/ovti
> ,ov2685.yaml
Right, since Sakari changed maxItems=1 to maxItems=2, now minItems is also 2
but it should be 1. I'll send a patch to fix this.
Regards
Luca