Re: [PATCH v2] stm: class: Add MIPI OST protocol support

From: kernel test robot
Date: Wed Apr 19 2023 - 14:27:29 EST

Hi Mao,

kernel test robot noticed the following build errors:

[auto build test ERROR on atorgue-stm32/stm32-next]
[also build test ERROR on linus/master v6.3-rc7 next-20230418]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Mao-Jinlong/stm-class-Add-MIPI-OST-protocol-support/20230419-221653
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
patch link: https://lore.kernel.org/r/20230419141328.37472-1-quic_jinlmao%40quicinc.com
patch subject: [PATCH v2] stm: class: Add MIPI OST protocol support
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230420/202304200216.kvZgZcao-lkp@xxxxxxxxx/config)
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/54db7d137859caf5a14de2b166d80913b0c80218
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Mao-Jinlong/stm-class-Add-MIPI-OST-protocol-support/20230419-221653
git checkout 54db7d137859caf5a14de2b166d80913b0c80218
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202304200216.kvZgZcao-lkp@xxxxxxxxx/

All error/warnings (new ones prefixed by >>):

drivers/hwtracing/stm/p_ost.c: In function 'ost_write':
>> drivers/hwtracing/stm/p_ost.c:174:46: error: implicit declaration of function 'get_current'; did you mean 'get_cred'? [-Werror=implicit-function-declaration]
174 | *(u64 *)(trc_hdr + 8) = task_tgid_nr(get_current());
| ^~~~~~~~~~~
| get_cred
>> drivers/hwtracing/stm/p_ost.c:174:46: warning: passing argument 1 of 'task_tgid_nr' makes pointer from integer without a cast [-Wint-conversion]
174 | *(u64 *)(trc_hdr + 8) = task_tgid_nr(get_current());
| ^~~~~~~~~~~~~
| |
| int
In file included from include/linux/sched/mm.h:7,
from include/linux/xarray.h:19,
from include/linux/radix-tree.h:21,
from include/linux/idr.h:15,
from include/linux/kernfs.h:12,
from include/linux/sysfs.h:16,
from include/linux/kobject.h:20,
from include/linux/module.h:21,
from drivers/hwtracing/stm/p_ost.c:9:
include/linux/sched.h:1582:54: note: expected 'struct task_struct *' but argument is of type 'int'
1582 | static inline pid_t task_tgid_nr(struct task_struct *tsk)
| ~~~~~~~~~~~~~~~~~~~~^~~
cc1: some warnings being treated as errors


vim +174 drivers/hwtracing/stm/p_ost.c

131
132 static ssize_t notrace ost_write(struct stm_data *data,
133 struct stm_output *output, unsigned int chan,
134 const char *buf, size_t count)
135 {
136 unsigned int c = output->channel + chan;
137 unsigned int m = output->master;
138 const unsigned char nil = 0;
139 u32 header = DATA_HEADER;
140 u8 trc_hdr[16];
141 ssize_t sz;
142
143 struct ost_output *op = output->pdrv_private;
144
145 /*
146 * Identify the source by entity type.
147 * If entity type is not set, return error value.
148 */
149 if (op->node.entity_type == OST_ENTITY_TYPE_FTRACE) {
150 header |= OST_ENTITY_FTRACE;
151 } else if (op->node.entity_type == OST_ENTITY_TYPE_CONSOLE) {
152 header |= OST_ENTITY_CONSOLE;
153 } else {
154 pr_debug("p_ost: Entity must be set for trace data.");
155 return -EINVAL;
156 }
157
158 /*
159 * STP framing rules for OST frames:
160 * * the first packet of the OST frame is marked;
161 * * the last packet is a FLAG with timestamped tag.
162 */
163 /* Message layout: HEADER / DATA / TAIL */
164 /* HEADER */
165 sz = data->packet(data, m, c, STP_PACKET_DATA, STP_PACKET_MARKED,
166 4, (u8 *)&header);
167 if (sz <= 0)
168 return sz;
169
170 /* DATA */
171 *(u16 *)(trc_hdr) = STM_MAKE_VERSION(0, 4);
172 *(u16 *)(trc_hdr + 2) = STM_HEADER_MAGIC;
173 *(u32 *)(trc_hdr + 4) = raw_smp_processor_id();
> 174 *(u64 *)(trc_hdr + 8) = task_tgid_nr(get_current());
175 sz = stm_data_write(data, m, c, false, trc_hdr, sizeof(trc_hdr));
176 if (sz <= 0)
177 return sz;
178
179 sz = stm_data_write(data, m, c, false, buf, count);
180
181 /* TAIL */
182 if (sz > 0)
183 data->packet(data, m, c, STP_PACKET_FLAG,
184 STP_PACKET_TIMESTAMPED, 0, &nil);
185
186 return sz;
187 }
188

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests