Re: [PATCH] io_uring: Optimization of buffered random write
From: kernel test robot
Date: Wed Apr 19 2023 - 15:27:17 EST
Hi luhongfei,
kernel test robot noticed the following build errors:
[auto build test ERROR on linus/master]
[also build test ERROR on v6.3-rc7 next-20230418]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/luhongfei/io_uring-Optimization-of-buffered-random-write/20230419-172539
patch link: https://lore.kernel.org/r/20230419092233.56338-1-luhongfei%40vivo.com
patch subject: [PATCH] io_uring: Optimization of buffered random write
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20230420/202304200351.LIOui4Xc-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/620dbcc5ab192992f08035fd9d271ffffb8ff043
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review luhongfei/io_uring-Optimization-of-buffered-random-write/20230419-172539
git checkout 620dbcc5ab192992f08035fd9d271ffffb8ff043
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 olddefconfig
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202304200351.LIOui4Xc-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
io_uring/io_uring.c: In function 'io_queue_sqe':
>> io_uring/io_uring.c:2091:30: error: 'struct io_kiocb' has no member named 'rw'
2091 | if (!is_write || (req->rw.kiocb.ki_flags & IOCB_DIRECT))
| ^~
vim +2091 io_uring/io_uring.c
2073
2074 static inline void io_queue_sqe(struct io_kiocb *req)
2075 __must_hold(&req->ctx->uring_lock)
2076 {
2077 int ret;
2078 bool is_write;
2079
2080 switch (req->opcode) {
2081 case IORING_OP_WRITEV:
2082 case IORING_OP_WRITE_FIXED:
2083 case IORING_OP_WRITE:
2084 is_write = true;
2085 break;
2086 default:
2087 is_write = false;
2088 break;
2089 }
2090
> 2091 if (!is_write || (req->rw.kiocb.ki_flags & IOCB_DIRECT))
2092 ret = io_issue_sqe(req, IO_URING_F_NONBLOCK|IO_URING_F_COMPLETE_DEFER);
2093 else
2094 ret = io_issue_sqe(req, 0);
2095
2096 /*
2097 * We async punt it if the file wasn't marked NOWAIT, or if the file
2098 * doesn't support non-blocking read/write attempts
2099 */
2100 if (likely(!ret))
2101 io_arm_ltimeout(req);
2102 else
2103 io_queue_async(req, ret);
2104 }
2105
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests