Re: [PATCH] firmware:Remove unnecessary (void*) conversions

From: Marek Behún
Date: Thu Apr 20 2023 - 06:37:25 EST


This makes sense, but the commit title should be
firmware: turris-mox-rwtm: drop unnecessary (void *) conversion

On Thu, Apr 20, 2023 at 03:37:51PM +0800, yunchuan wrote:
> Pointer variables of void * type do not require type cast.
>
> Signed-off-by: yunchuan <yunchuan@xxxxxxxxxxxx>
> ---
> drivers/firmware/turris-mox-rwtm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/turris-mox-rwtm.c b/drivers/firmware/turris-mox-rwtm.c
> index 6ea5789a89e2..af2fa620e6bc 100644
> --- a/drivers/firmware/turris-mox-rwtm.c
> +++ b/drivers/firmware/turris-mox-rwtm.c
> @@ -283,7 +283,7 @@ static int check_get_random_support(struct mox_rwtm *rwtm)
>
> static int mox_hwrng_read(struct hwrng *rng, void *data, size_t max, bool wait)
> {
> - struct mox_rwtm *rwtm = (struct mox_rwtm *) rng->priv;
> + struct mox_rwtm *rwtm = rng->priv;
> struct armada_37xx_rwtm_tx_msg msg;
> int ret;
>
> --
> 2.30.2
>