Re: [PATCH v3 1/2] dt-bindings: clock: Add SM8350 VIDEOCC

[Krzysztof Kozlowski]

On 19/04/2023 14:53, Konrad Dybcio wrote:
> SM8350, like most recent higher-end chips has a separate clock
> controller block just for the Venus IP. Document it.
> 
> The binding was separated as the driver, unlike the earlier ones, doesn't
> expect clock-names to keep it easier to maintain.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---
>  .../bindings/clock/qcom,sm8350-videocc.yaml        | 81 ++++++++++++++++++++++
>  include/dt-bindings/clock/qcom,sm8350-videocc.h    | 35 ++++++++++
>  include/dt-bindings/reset/qcom,sm8350-videocc.h    | 18 +++++
>  3 files changed, 134 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml
> new file mode 100644
> index 000000000000..28a1002b1563
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml
> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/qcom,sm8350-videocc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm SM8350 Video Clock & Reset Controller
> +
> +maintainers:
> +  - Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> +
> +description: |
> +  Qualcomm video clock control module provides the clocks, resets and power
> +  domains on Qualcomm SoCs.
> +
> +  See also::
> +    include/dt-bindings/clock/qcom,videocc-sm8350.h
> +    include/dt-bindings/reset/qcom,videocc-sm8350.h
> +
> +properties:
> +  compatible:
> +    const: qcom,sm8350-videocc
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: Board XO source
> +      - description: Board active XO source
> +      - description: Board sleep clock
> +
> +  power-domains:
> +    description:
> +      A phandle and PM domain specifier for the MMCX power domain.
> +    maxItems: 1
> +
> +  required-opps:
> +    description:
> +      A phandle to an OPP node describing required MMCX performance point.
> +    maxItems: 1
> +
> +  '#clock-cells':
> +    const: 1
> +
> +  '#reset-cells':
> +    const: 1
> +
> +  '#power-domain-cells':
> +    const: 1

Everything is the same as gcc.yaml, so add a allOf:$ref to it, drop
unnecessary properties and use unevaluatedProperties: false.

Best regards,
Krzysztof