Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Drop unused members from HW structs

[Dmitry Baryshkov]

On 21/04/2023 00:39, Marijn Suijten wrote:
> On 2023-04-20 08:46:46, Abhinav Kumar wrote:
> > On 4/20/2023 7:33 AM, Dmitry Baryshkov wrote:
> > > On 18/04/2023 02:14, Marijn Suijten wrote:
> > > > Some of these members were initialized while never read, while others
> > > > were not even assigned any value at all.  Drop them to save some space,
> > > > and above all confusion when looking at these members.
> > > >
> > > > Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
> > > > Fixes: 84a33d0fd921 ("drm/msm/dpu: add dpu_hw_wb abstraction for
> > > > writeback blocks")
> > >
> > > The fixes headers are slightly questionable, as unused fields are not a
> > > bug. Nevertheless:
> >
> > Yes, I would also not treat this as a "fix" but just cleanup.
>
> Ack to both.  This seems like a fine line to me as the fields are not
> contributing to anything except confusion.  Specifically hw_mdp which is
> never initialized and may accidentally be used without realizing that
> it'll stay NULL, but that is again up to the developer using the field
> at that point.
>
> Feel free to drop them while applying, or should I reword the message to
> at least still link these commits to mention the origin of the unused
> fields?

I'm fine with having the Fixes removed. If you can send the v2 reordered 
& with tags removed, that would be the best.

> - Marijn

--
With best wishes
Dmitry