Re: [PATCH 1/1] perf probe: Add missing 0x prefix for addresses printed in hexadecimal

[Google]

On Wed, 19 Apr 2023 16:36:40 -0300
arnaldo.melo@xxxxxxxxx wrote:

> Hi Masami,
> 
> 	I'm carrying this one in my tree, FYI.

Thanks! this looks good to me!

Acked-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>

> 
> - Arnaldo
> 
> ---
> 
> To fix this confusing warning:
> 
>   # perf probe -l
>   Failed to find debug information for address 798240
>     probe_main:prometheus_new_counter__return (on github.com/prometheus/client_golang/prometheus.NewCounter%return in /home/acme/git/prometheus-uprobes/main with counter)
>   #
> 
> As that 798240 is printed with PRIx64 but has no letters, better print
> the 0x prefix to disambiguate.
> 
> Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> Cc: Ian Rogers <irogers@xxxxxxxxxx>
> Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> Cc: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> Link: https://lore.kernel.org/lkml/
> Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> ---
>  tools/perf/util/probe-finder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
> index 54b49ce85c9f2214..f171360b0ef4db06 100644
> --- a/tools/perf/util/probe-finder.c
> +++ b/tools/perf/util/probe-finder.c
> @@ -1729,7 +1729,7 @@ int debuginfo__find_probe_point(struct debuginfo *dbg, u64 addr,
>  		addr += baseaddr;
>  	/* Find cu die */
>  	if (!dwarf_addrdie(dbg->dbg, (Dwarf_Addr)addr, &cudie)) {
> -		pr_warning("Failed to find debug information for address %" PRIx64 "\n",
> +		pr_warning("Failed to find debug information for address %#" PRIx64 "\n",
>  			   addr);
>  		ret = -EINVAL;
>  		goto end;
> -- 
> 2.39.2
> 


-- 
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>