Re: [PATCH v1] usb: phy: add usb phy notify port status API

[Greg Kroah-Hartman]

On Fri, Apr 21, 2023 at 08:32:19AM +0000, Stanley Chang[昌育德] wrote:
> > 
> > On Fri, Apr 21, 2023 at 04:03:31PM +0800, Stanley Chang wrote:
> > > In Realtek SoC, the parameter of usb phy is designed to can dynamic
> > > tuning base on port status. Therefore, add a notify callback of phy
> > > driver when usb port status change.
> > >
> > > Signed-off-by: Stanley Chang <stanley_chang@xxxxxxxxxxx>
> > > ---
> > >  drivers/usb/core/hub.c  | 13 +++++++++++++  include/linux/usb/phy.h |
> > > 14 ++++++++++++++
> > >  2 files changed, 27 insertions(+)
> > 
> > We can not add callbacks in the kernel that are not actually used, otherwise
> > they will just be instantly removed.
> > 
> > Please submit any drivers that need this change at the same time so that we
> > can verify that the callback is actually correct and needed, otherwise we can
> > not take this change.
> > 
> 
> In this stage, we usb phy driver is not at linux upstream. 

Then obviously we can not take this change (nor would you want us to.)

> For the android GKI, we have to add this callback to upstream or use the vendor hook of android.
> I will plan to upstream the realtek usb phy driver.

As you already have this driver, why not send it to us now?

thanks,

greg k-h