Re: [PATCH 1/1] regulator: pca9450: Fix BUCK2 enable_mask

[Alexander Stein]

Hi,

Am Montag, 13. März 2023, 15:38:52 CEST schrieb Frieder Schrempf:
> On 13.03.23 15:21, Alexander Stein wrote:
> > Hi Frieder,
> > 
> > thanks for your comments.
> > 
> > Am Montag, 13. März 2023, 14:46:08 CET schrieb Frieder Schrempf:
> >> On 10.03.23 10:28, Alexander Stein wrote:
> >>> This fixes a copy & paste error.
> >> 
> >> I would mention here, that this doesn't contain any functional changes
> >> as BUCK1_ENMODE_MASK is equal to BUCK2_ENMODE_MASK.
> > 
> > That's a good idea.
> > 
> >>> Fixes: 0935ff5f1f0a ("regulator: pca9450: add pca9450 pmic driver")
> >>> Originally-from: Robin Gong <yibin.gong@xxxxxxx>
> >>> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> >>> ---
> >>> This diff is extracted from a downstream commit authored by Robin Gong.
> >>> I'm not sure if adding Originally-from: is enough here or I do have to
> >>> change From: as well.
> >> 
> >> I never heard of "Originally-from:". Does this tag exist? Is it
> >> documented somewhere?
> > 
> > Well, it's not documented, but it pops up occasionally in some commits,
> > e.g. 3fb906e7fabbb ("cgroup/cpuset: Don't filter offline CPUs in
> > cpuset_cpus_allowed() for top cpuset tasks")
> > I might be something only some maintainers accept though.
> > 
> >> I think that your tooling (git format-patch) should add a From: tag
> >> automatically if you correctly pick up a patch from someone else.
> > 
> > Well, it's not exactly cherry-picked, but extracted from an existing
> > commit
> > [1], so that's maybe why my name has been put into From: while extracting.
> > As the diff in this patch is not exactly the same as from the origin, I
> > did
> > not want to put Robin Gong into Signed-off-by. And I think having an
> > author in From: but not in Signed-off-by: tag should not happen.
> > Searching how I can still give credit I found Originally-from. If there is
> > a better way to handle this, I'm ready to adapt to that.
> 
> Ok, good question. I currently have a similar case somewhere else and
> I'm also not really sure how to handle it properly. I don't think we are
> ever allowed to add a Signed-off-by tag for someone else.
> Maybe "Originally-from" is correct for this case but I never really like
> to use tags that aren't generally accepted or documented somewhere.

Could some of the maintainers make a call here, how to address the original 
author where the change is taken from? Note: It is not cherry-picked, but only 
some hunks are taken.
Thanks

Best regards,
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/