Re: [PATCH v2] sh: Replace <uapi/asm/types.h> by <asm-generic/int-ll64.h>

[Geert Uytterhoeven]

Hi Adrian,

On Fri, Apr 21, 2023 at 1:14 PM John Paul Adrian Glaubitz
<glaubitz@xxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, 2023-03-23 at 11:22 +0100, Geert Uytterhoeven wrote:
> > As arch/sh/include/uapi/asm/types.h doesn't exist, sh doesn't provide
> > any sh-specific uapi definitions, and it can just include
> > <asm-generic/int-ll64.h>, like most other architectures.
> >
> > Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > ---
> > v2:
> >   - Rebased for SPDX-License-Identifier addition in 2017.
> >
> >  arch/sh/include/asm/types.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/sh/include/asm/types.h b/arch/sh/include/asm/types.h
> > index 68eb24ad201383ef..9b3fc923ee28701c 100644
> > --- a/arch/sh/include/asm/types.h
> > +++ b/arch/sh/include/asm/types.h
> > @@ -2,7 +2,7 @@
> >  #ifndef __ASM_SH_TYPES_H
> >  #define __ASM_SH_TYPES_H
> >
> > -#include <uapi/asm/types.h>
> > +#include <asm-generic/int-ll64.h>
> >
> >  /*
> >   * These aren't exported outside the kernel to avoid name space clashes
>
> It seems that many (most?) architectures don't even provide their own types.h
> header. Does it even make sense to still carry that header or can it be provided
> from somewhere else?

SH does because it defines extra types {insn,reg}_size_t.
We can get rid of it by moving these extra types elsewhere, but is that
worth the effort?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds