Re: [PATCH 1/1] ufs: core: fix &hwq->cq_lock deadlock issue

From: Bart Van Assche
Date: Fri Apr 21 2023 - 13:26:17 EST


On 4/21/23 00:56, Alice Chao wrote:
When ufshcd_err_handler() is executed, CQ event interrupt can enter
waiting for the same lock. It could happened in upstream code path
ufshcd_handle_mcq_cq_events() and also in ufs_mtk_mcq_intr(). This
warning message will be generated when &hwq->cq_lock is used in IRQ
context with IRQ enabled. Use ufshcd_mcq_poll_cqe_lock() with
spin_lock_irqsave instead of spin_lock to resolve the deadlock issue.

Please add a Fixes: tag.

Thanks,

Bart.