Re: [syzbot] [kernel?] KCSAN: data-race in do_timer_create / do_timer_create (8)
From: Thomas Gleixner
Date: Fri Apr 21 2023 - 18:38:04 EST
On Fri, Apr 21 2023 at 16:49, Dmitry Vyukov wrote:
> int first_free_id = sig->posix_timer_id;
>
> runs concurrently with:
>
> if (++sig->posix_timer_id < 0)
> sig->posix_timer_id = 0;
> if ((sig->posix_timer_id == first_free_id) && (ret == -ENOENT))
> /* Loop over all possible ids completed */
> ret = -EAGAIN;
>
> I am not sure how important/realistic this wrap-around handling is,
> but as the result of the race first_free_id can be negative (if it
> reads the value at just the right moment). Then wrap-around will never
> be detected and the loop will loop forever uninterruptably.
It's probably not that problematic, but that code is silly for other
reasons. I'll have a look.
Thanks,
tglx