Re: [PATCH 1/2] fbdev/offb: Update expected device name

[Helge Deller]

On 4/12/23 11:55, Cyril Brulebois wrote:
> Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"),
> as spotted by Frédéric Bonnard, the historical "of-display" device is
> gone: the updated logic creates "of-display.0" instead, then as many
> "of-display.N" as required.
>
> This means that offb no longer finds the expected device, which prevents
> the Debian Installer from setting up its interface, at least on ppc64el.
>
> It might be better to iterate on all possible nodes, but updating the
> hardcoded device from "of-display" to "of-display.0" is confirmed to fix
> the Debian Installer at the very least.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217328
> Link: https://bugs.debian.org/1033058
> Fixes: 241d2fb56a18 ("of: Make OF framebuffer device names unique")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Cyril Brulebois <cyril@xxxxxxxxxxx>

I've applied the series (2 patches, one of them in drm) to the fbdev git tree.

Thanks!
Helge

> ---
>   drivers/video/fbdev/offb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
> index b97d251d894b..6264c7184457 100644
> --- a/drivers/video/fbdev/offb.c
> +++ b/drivers/video/fbdev/offb.c
> @@ -698,7 +698,7 @@ MODULE_DEVICE_TABLE(of, offb_of_match_display);
>
>   static struct platform_driver offb_driver_display = {
>   	.driver = {
> -		.name = "of-display",
> +		.name = "of-display.0",
>   		.of_match_table = offb_of_match_display,
>   	},
>   	.probe = offb_probe_display,